Files
support_backend/tests/integration/product-integrations-admin.test.ts
T
saqib mirandClaude Sonnet 5 2edfbacf82 feat: implement ticket creation, messages & attachments (003-ticketing)
Implements all 39 tasks from specs/003-ticketing/tasks.md across all
three user stories -- Phase 5 of the roadmap.

Schema (prisma/schema.prisma + migration):
- Ticket (code, status, version for optimistic concurrency,
  idempotencyKey, customerId FK), Problem, TicketMessage,
  TicketAttachment per docs/06, with Product/Category/
  CustomerReference back-relations.

User Story 1 -- ticket/problem creation (P1, MVP):
- Explicit 12-state lifecycle adjacency table
  (ticket-state-machine.ts), not "any transition allowed."
- Ticket code generation (<PRODUCT_CODE>-<YEAR>-<SEQUENCE>) scoped
  by the actual code prefix, not productId -- see the collision bug
  fixed below.
- Idempotency-key enforcement via atomic create-then-catch-conflict
  (never a read-then-write race), completing the FR-012 placeholder
  from 002-saas-integration.
- Explicit-reference-only recurring-problem linking (no fuzzy
  matching -- that's a future AI-support concern).
- POST /v1/support/requests (002-saas-integration) now creates a
  real ticket instead of echoing context back.
- PATCH /tickets/:id/status with expectedVersion-based optimistic
  concurrency (409 on stale version, 400 on an invalid transition).

User Story 2 -- typed messages (P2):
- Message type -> visibleToCustomer mapping is a fixed constant map,
  never caller-supplied; customer-scoped reads filter at the query
  layer so an internal note is never fetched, not just hidden.
- POST/GET /tickets/:id/messages (customer-scoped) and
  GET /agent/tickets/:id/messages (agent-scoped).

User Story 3 -- attachment pipeline (P3):
- Presigned-PUT upload (new getPresignedUploadUrl on the existing
  storageService) -- file bytes never transit this API.
- A MalwareScanner interface with a fail-closed placeholder
  (UnimplementedPlaceholderScanner) since no scanner exists in this
  stack -- it always reports 'infected', never silently 'clean'.
- The existing attachments-queue job stub now actually calls the
  scanner and updates scanStatus; registerAttachmentWorker() is
  wired into bootstrapQueue() (previously defined but never called).
- Downloads are gated on scanStatus === 'clean' -- currently always
  refused until a real scanner replaces the placeholder.
- MinIO added to docker-compose.{test,development}.yml for local/CI
  S3-compatible storage, matching doc 04's explicit guidance.

Two real bugs found and fixed via integration testing against a
live Postgres/Redis/MinIO (not just typechecked):
- Ticket codes could collide across different products: the
  sequence counter was scoped by internal productId, but the code
  column's uniqueness is global, and deriveProductCode's 4-character
  truncation means different products can share a prefix. Fixed by
  counting against the actual code prefix instead.
- Three existing 002-saas-integration integration tests' cleanup
  started failing an FK RESTRICT check once ticket creation was
  wired in (deleting a Product before the Ticket/Problem that now
  reference it). Fixed their afterAll ordering.

All 9 integration test files (24 tests, spanning this feature and
the pre-existing suite) verified passing against real Postgres,
Redis, and MinIO, including a genuine presigned-PUT/GET round trip.
Full quality gate (typecheck/lint/format/architecture/unit tests)
passes.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
2026-09-02 15:21:37 +05:30

143 lines
5.4 KiB
TypeScript

import { describe, it, expect, afterAll } from 'vitest';
import { buildApp } from '@/app';
import { prismaClient } from '@/infrastructure/database';
import { FastifyInstance } from 'fastify';
import { issueIntegrationToken } from '@/modules/catalog/products';
/**
* Covers specs/002-saas-integration/quickstart.md Scenarios 5-7 (rotation zero-downtime,
* revocation is immediate, audit trail is retrievable) against a real Postgres/Redis. See
* specs/002-saas-integration/checklists/requirements.md implementation notes for the known
* DATABASE_URL wiring gap this test shares with tests/integration/product-integration-auth.test.ts.
*/
describe('Product Integration Admin Lifecycle', () => {
let app: FastifyInstance;
const externalProductId = `TEST_ADMIN_PROD_${Date.now()}`;
afterAll(async () => {
// A successful request now also creates a Ticket/Problem (specs/003-ticketing) — those
// must be cleaned up before the Product they reference, or the FK RESTRICT blocks it.
await prismaClient.ticketMessage.deleteMany({
where: { ticket: { product: { externalProductId } } },
});
await prismaClient.ticket.deleteMany({ where: { product: { externalProductId } } });
await prismaClient.problem.deleteMany({ where: { product: { externalProductId } } });
await prismaClient.productIntegration.deleteMany({
where: { product: { externalProductId } },
});
await prismaClient.product.deleteMany({ where: { externalProductId } });
await app.close();
});
it('Scenario 5+7: register, then rotate — both old and new credential work during the transition window, and the audit trail records every step', async () => {
app = await buildApp();
const registerResponse = await app.inject({
method: 'POST',
url: `/admin/products/${externalProductId}/integration`,
payload: {
name: 'Admin Test Product',
allowedScope: { tenantIds: ['tenant-1'] },
},
});
expect(registerResponse.statusCode).toBe(201);
const registered = registerResponse.json().data;
const originalSecret = registered.credentialSecret;
const integrationId = registered.integrationId;
const rotateResponse = await app.inject({
method: 'POST',
url: `/admin/integrations/${integrationId}/rotate`,
});
expect(rotateResponse.statusCode).toBe(200);
const rotated = rotateResponse.json().data;
const newSecret = rotated.credentialSecret;
expect(newSecret).not.toBe(originalSecret);
const oldTokenRequest = await app.inject({
method: 'POST',
url: '/v1/support/requests',
headers: {
authorization: `Bearer ${issueIntegrationToken(originalSecret, { externalProductId, tenantId: 'tenant-1', userId: 'user-1' })}`,
},
payload: {
productId: externalProductId,
tenantId: 'tenant-1',
userId: 'user-1',
source: 'test',
problem: 'old credential still valid during transition',
},
});
const newTokenRequest = await app.inject({
method: 'POST',
url: '/v1/support/requests',
headers: {
authorization: `Bearer ${issueIntegrationToken(newSecret, { externalProductId, tenantId: 'tenant-1', userId: 'user-2' })}`,
},
payload: {
productId: externalProductId,
tenantId: 'tenant-1',
userId: 'user-2',
source: 'test',
problem: 'new credential valid',
},
});
expect(oldTokenRequest.statusCode).toBe(202);
expect(newTokenRequest.statusCode).toBe(202);
const auditResponse = await app.inject({
method: 'GET',
url: `/admin/integrations/${integrationId}/audit-trail`,
});
expect(auditResponse.statusCode).toBe(200);
const actions = auditResponse.json().data.map((e: { action: string }) => e.action);
expect(actions).toContain('integration.registered');
expect(actions).toContain('integration.rotated');
expect(actions.filter((a: string) => a === 'integration.auth.success')).toHaveLength(2);
});
it('Scenario 6: revocation takes effect on the very next request', async () => {
const registerResponse = await app.inject({
method: 'POST',
url: `/admin/products/${externalProductId}-revoke/integration`,
payload: {
name: 'Admin Test Product Revoke',
allowedScope: { tenantIds: ['tenant-1'] },
},
});
const { credentialSecret, integrationId } = registerResponse.json().data;
const revokeResponse = await app.inject({
method: 'POST',
url: `/admin/integrations/${integrationId}/revoke`,
});
expect(revokeResponse.statusCode).toBe(200);
const requestAfterRevoke = await app.inject({
method: 'POST',
url: '/v1/support/requests',
headers: {
authorization: `Bearer ${issueIntegrationToken(credentialSecret, { externalProductId: `${externalProductId}-revoke`, tenantId: 'tenant-1', userId: 'user-1' })}`,
},
payload: {
productId: `${externalProductId}-revoke`,
tenantId: 'tenant-1',
userId: 'user-1',
source: 'test',
problem: 'should be rejected',
},
});
expect(requestAfterRevoke.statusCode).toBe(401);
expect(requestAfterRevoke.json().error.code).toBe('INVALID_INTEGRATION_CREDENTIAL');
await prismaClient.productIntegration.deleteMany({
where: { product: { externalProductId: `${externalProductId}-revoke` } },
});
await prismaClient.product.deleteMany({
where: { externalProductId: `${externalProductId}-revoke` },
});
});
});